Skip to content

Increase test coverage for core vector classes to 100% #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Increase test coverage for core vector classes to 100% #4

Copilot wants to merge 5 commits into from
+341 −0

Conversation

Copy link

Copilot AI commented Jan 14, 2026 •
edited
Loading

Test coverage for core vector classes (Vector, HalfVector, Bit, SparseVector) was at 66-82%, with critical database conversion methods and edge cases untested.

Changes

Database Adapter Coverage

  • Added tests for _to_db(), _to_db_binary(), _from_db(), _from_db_binary() methods
  • Covers None handling, dimension validation, type conversion paths

Serialization Coverage

  • Added to_text(), from_text(), to_binary(), from_binary() tests for Bit class
  • Added roundtrip serialization tests for all classes

Edge Cases

  • Empty vectors, single elements, negative values
  • Type inequality comparisons (e.g., Vector([1,2,3]) != [1,2,3])
  • Sparse arrays with invalid dimensions
  • Float precision handling

Error Conditions

  • Dimension mismatch in _to_db(dim=N)
  • Invalid type errors in Bit _to_db() methods
  • Invalid binary format errors

Coverage Impact

Class Before After
Vector 66% 100%
HalfVector 66% 100%
Bit 72% 100%
SparseVector 82% 99%

Test count: 58 → 135 (+77 tests)

Note: SparseVector's missing 1% is scipy version compatibility code at line 90 (fallback for scipy <1.13).

Original prompt

This section details on the original issue you should resolve

<issue_title>Correggi i tests in questo repo</issue_title>
<issue_description>I test in questo repo non hanno una coverage molto alta, puoi aumentarla o comunque aggiungere dettagli a quelli gia' presenti. </issue_description>

<agent_instructions>just do it</agent_instructions>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 4 commits January 14, 2026 09:59
@jackrua
Initial exploration of test coverage
b65f5a5 
Co-authored-by: jackrua <155536850+jackrua@users.noreply.github.com>
@jackrua
Add comprehensive tests for core vector classes
4779b97 
Co-authored-by: jackrua <155536850+jackrua@users.noreply.github.com>
@jackrua
Add edge case tests for equality comparisons, achieve 100% coverage o…
f779a1b 
…n Vector/HalfVector/Bit

Co-authored-by: jackrua <155536850+jackrua@users.noreply.github.com>
@jackrua
Fix misleading comment in test as per code review feedback
bd2a0b6 
Co-authored-by: jackrua <155536850+jackrua@users.noreply.github.com>
Copilot AI changed the title [WIP] Increase test coverage in the repository Increase test coverage for core vector classes to 100% Jan 14, 2026
Copilot AI requested a review from jackrua January 14, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackrua jackrua Awaiting requested review from jackrua

Assignees

@jackrua jackrua

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correggi i tests in questo repo

2 participants

@jackrua